sdk/lib/_internal/compiler/implementation/lib/js_string.dart - Issue 16206008: Fix-up RegExp implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

Issue 16206008: Fix-up RegExp implementations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Renaming startIndex to index. Add comment. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/js_string.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_string.dart b/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

index 610f7f812d97450f8f0d56f4e3d2d2b2459ed87f..92d7c673a2a62bc8da0b152e3afa0a81c59d5bdb 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_string.dart

@@ -222,6 +222,9 @@ class JSString extends Interceptor implements String, JSIndexable {

bool contains(Pattern other, [int startIndex = 0]) {

checkNull(other);

+ if (startIndex < 0 || startIndex > this.length) {

+ throw new RangeError.range(startIndex, 0, this.length);

+ }

return stringContainsUnchecked(this, other, startIndex);

}