sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart - Issue 16206008: Fix-up RegExp implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

Issue 16206008: Fix-up RegExp implementations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Renaming startIndex to index. Add comment. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

index f8243c5ad5fb0a1cc47e6577118616d75c8a11ba..1e6bc7bfcd5d8134e9554d0f40dfff60e6e3587c 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/regexp_helper.dart

@@ -136,6 +136,10 @@ class _AllMatchesIterator implements Iterator<Match> {

bool moveNext() {

// firstMatch actually acts as nextMatch because of

// hidden global flag.

+ if (_current != null && _current.start == _current.end) {

+ // Advance implicit start-position if last match was empty.

+ JS("void", "#.lastIndex++", _re._nativeRegExp);

+ }

_current = _re.firstMatch(_str);

return _current != null;

}