Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 16191004: Fix bug in SsaConstructionFieldTypes where the phase got confused seeing multiple HForeignNew due t… (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, sra1, dgrove, ricow1, Søren Gjesse
Visibility:
Public.

Description

Fix bug in SsaConstructionFieldTypes where the phase got confused seeing multiple HForeignNew due to inlining. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23327

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A tests/language/field_inference_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-05-29 08:12:01 UTC) #1
kasperl
LGTM!
7 years, 6 months ago (2013-05-29 08:24:59 UTC) #2
ngeoffray
7 years, 6 months ago (2013-05-29 08:29:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698