Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 16191004: Fix bug in SsaConstructionFieldTypes where the phase got confused seeing multiple HForeignNew due t… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/field_inference_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 23325)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -1437,6 +1437,11 @@
}
visitForeignNew(HForeignNew node) {
+ if (!work.element.isGenerativeConstructor()) return;
+ // Check if this is the new object allocated by this generative
+ // constructor. Inlining might add other [HForeignNew]
+ // instructions in the graph.
+ if (!node.usedBy.any((user) => user is HReturn)) return;
// The HForeignNew instruction is used in the generative constructor to
// initialize all fields in newly created objects. The fields are
// initialized to the value present in the initializer list or set to null
« no previous file with comments | « no previous file | tests/language/field_inference_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698