Fix bug in SsaConstructionFieldTypes where the phase got confused seeing multiple HForeignNew due t…

sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class OptimizationPhase {
   String get name;
   void visitGraph(HGraph graph);
 }
@@ skipping 1419 matching lines @@
     // Collect all users of this in a set to make the this exposed check simple
     // and cheap.
     thisUsers.addAll(instruction.usedBy);
   }
 
   visitFieldGet(HInstruction _) {
     // The field get instruction is allowed to use this.
   }
 
   visitForeignNew(HForeignNew node) {
+    if (!work.element.isGenerativeConstructor()) return;
+    // Check if this is the new object allocated by this generative
+    // constructor. Inlining might add other [HForeignNew]
+    // instructions in the graph.
+    if (!node.usedBy.any((user) => user is HReturn)) return;
     // The HForeignNew instruction is used in the generative constructor to
     // initialize all fields in newly created objects. The fields are
     // initialized to the value present in the initializer list or set to null
     // if not otherwise initialized.
     // Here we handle members in superclasses as well, as the handling of
     // the generative constructor bodies will ensure, that the initializer
     // type will not be used if the field is in any of these.
     int j = 0;
     node.element.forEachInstanceField(
         (ClassElement enclosingClass, Element element) {
@@ skipping 31 matching lines @@
     }
 
     // For other fields having setters in the generative constructor body, set
     // the type to UNKNOWN to avoid relying on the type set in the initializer
     // list.
     allSetters.forEach((Element element) {
       backend.registerFieldConstructor(element, HType.UNKNOWN);
     });
   }
 }