Issue 160343002: Implement reflection on annotations of parameters.

Issue 160343002: Implement reflection on annotations of parameters. (Closed)

Created:
6 years, 10 months ago by karlklose

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement reflection on annotations of parameters. R=floitsch@google.com BUG= http://dartbug.com/15820 Committed: https://code.google.com/p/dart/source/detail?r=32600

Patch Set 2 : Address comment. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/builder.dart	View		1 chunk	+3 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1	4 chunks	+13 lines, -6 lines	0 comments	Download
A	tests/lib/mirrors/parameter_annotation_mirror_test.dart	View		1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/160343002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/160343002/diff/1/sdk/lib/_internal/lib/js_helper.dart#newcode404 sdk/lib/_internal/lib/js_helper.dart:404: List<int> metadataAnnotations(int parameter) { since this is only ...

6 years, 10 months ago (2014-02-12 13:15:53 UTC) #2

karlklose

https://codereview.chromium.org/160343002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/160343002/diff/1/sdk/lib/_internal/lib/js_helper.dart#newcode404 sdk/lib/_internal/lib/js_helper.dart:404: List<int> metadataAnnotations(int parameter) { On 2014/02/12 13:15:54, floitsch wrote: ...

6 years, 10 months ago (2014-02-12 13:25:16 UTC) #4

karlklose

6 years, 10 months ago (2014-02-12 14:28:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r32600 (presubmit successful).

Expand Messages | Collapse Messages