sdk/lib/_internal/lib/js_helper.dart - Issue 160343002: Implement reflection on annotations of parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_helper.dart

Issue 160343002: Implement reflection on annotations of parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/lib/js_helper.dart

diff --git a/sdk/lib/_internal/lib/js_helper.dart b/sdk/lib/_internal/lib/js_helper.dart

index 8be9ee592b3efcc035648b8378fdfb97d5fdd004..92b23ad3fdb4cf11d8d94ae866e08c36fb77e2a2 100644

--- a/sdk/lib/_internal/lib/js_helper.dart

+++ b/sdk/lib/_internal/lib/js_helper.dart

@@ -396,11 +396,16 @@ class ReflectionInfo {

}

String parameterName(int parameter) {

- int metadataIndex = JS('int', '#[# + # + #]', data, parameter,

- optionalParameterCount, FIRST_DEFAULT_ARGUMENT);

+ int metadataIndex = JS('int', '#[2 * # + # + #]', data, parameter,

+ optionalParameterCount, FIRST_DEFAULT_ARGUMENT);

return JS('String', 'init.metadata[#]', metadataIndex);

}

+ List<int> parameterMetadataAnnotations(int parameter) {

+ return JS('', '#[2 * # + # + # + 1]', data, parameter,

+ optionalParameterCount, FIRST_DEFAULT_ARGUMENT);

+ }

int defaultValue(int parameter) {

if (parameter < requiredParameterCount) return null;

return JS('int', '#[# + # - #]', data,