sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart - Issue 160343002: Implement reflection on annotations of parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 160343002: Implement reflection on annotations of parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart ('k') | sdk/lib/_internal/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

index ee897b95e3039046f851af85871aa6adef84b53e..ba23aa4b008d3edc658d1605f135fa2b695aba20 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

@@ -98,7 +98,8 @@ String getReflectionDataParser(String classesCollector,

''' requiredParameterCount + optionalParameterCount != funcs[0].length;

var functionTypeIndex = ${readFunctionType("array", "2")};

var isReflectable =''' // Break long line.

- ''' array.length > requiredParameterCount + optionalParameterCount + 3;

+ ''' array.length > 3 * optionalParameterCount + ''' // Break

+ '''2 * requiredParameterCount + 3

if (getterStubName) {

f = tearOff(funcs, array, isStatic, name, isIntercepted);

'''

@@ -119,7 +120,7 @@ String getReflectionDataParser(String classesCollector,

}

if (isReflectable) {

var unmangledNameIndex =''' // Break long line.

- ''' optionalParameterCount * 2 + requiredParameterCount + 3;

+ ''' 3 * optionalParameterCount + 2 * requiredParameterCount + 3;

var unmangledName = ${readString("array", "unmangledNameIndex")};

var reflectionName =''' // Break long line.

''' unmangledName + ":" + requiredParameterCount +''' // Break long line.