Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 15945006: Fix leaf floating point runtime calls on ARM (work still needed in simulator). (Closed)

Created:
7 years, 6 months ago by regis
Modified:
7 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix leaf floating point runtime calls on ARM (work still needed in simulator). Various cleanups. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23506

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -48 lines) Patch
M runtime/vm/bigint_operations_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/constants_arm.h View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 12 chunks +23 lines, -25 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
7 years, 6 months ago (2013-05-31 23:26:04 UTC) #1
zra
lgtm
7 years, 6 months ago (2013-05-31 23:37:18 UTC) #2
regis
Thanks!
7 years, 6 months ago (2013-05-31 23:49:21 UTC) #3
regis
7 years, 6 months ago (2013-05-31 23:51:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698