runtime/vm/intrinsifier_arm.cc - Issue 15945006: Fix leaf floating point runtime calls on ARM (work still needed in simulator).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 15945006: Fix leaf floating point runtime calls on ARM (work still needed in simulator). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_arm.cc

===================================================================

--- runtime/vm/intrinsifier_arm.cc (revision 23505)

+++ runtime/vm/intrinsifier_arm.cc (working copy)

@@ -1390,13 +1390,13 @@

FlowGraphCompiler::DataOffsetFor(kTypedDataUint32ArrayCid);

__ LoadImmediate(R0, a_int32_value);

- __ LoadFromOffset(kLoadWord, R2, R1, disp_0 - 1);

- __ LoadFromOffset(kLoadWord, R3, R1, disp_1 - 1);

+ __ LoadFromOffset(kLoadWord, R2, R1, disp_0 - kHeapObjectTag);

+ __ LoadFromOffset(kLoadWord, R3, R1, disp_1 - kHeapObjectTag);

__ mov(R6, ShifterOperand(R3, ASR, 31)); // Sign extend into R6.

// 64-bit multiply and accumulate into R6:R3.

__ smlal(R3, R6, R0, R2); // R6:R3 <- R6:R3 + R0 * R2.

- __ StoreToOffset(kStoreWord, R3, R1, disp_0 - 1);

- __ StoreToOffset(kStoreWord, R6, R1, disp_1 - 1);

+ __ StoreToOffset(kStoreWord, R3, R1, disp_0 - kHeapObjectTag);

+ __ StoreToOffset(kStoreWord, R6, R1, disp_1 - kHeapObjectTag);

__ Ret();

return true;

}

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/runtime_entry.h » ('j') | no next file with comments »