Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.

Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.

There were basically two issues:
- localName and namespaceUri moved from Node down to Element.
- The transitionEnd event was polyfilled based on the deprecated webkitTransitionEnd event, so it was switched to the standard transtionEnd.

The Attr change was needed because the node map was using localName on Attr (inherited from Node), when it should have been using name. Attr is not actually exposed anywhere, so made it private.

BUG=
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23423

[Emily Fortuna, 2013-05-29 20:20:43]

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:23638: @deprecated // deprecated
nit, but why have the comment that says the same thing?

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:24890: keys.add(attributes[i].name);
I don't understand this change. I don't see a "name" field at all?

[blois, 2013-05-29 20:28:22]

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:23638: @deprecated // deprecated
On 2013/05/29 20:20:43, Emily Fortuna wrote:
> nit, but why have the comment that says the same thing?

This is a byproduct of the generation of the annotations from the metadata, they
were added for the initial review that you and Jacob did. I need to remove them
for the next step of metadata (not there yet).

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:24890: keys.add(attributes[i].name);
On 2013/05/29 20:20:43, Emily Fortuna wrote:
> I don't understand this change. I don't see a "name" field at all?

This is iterating through the attributes (type is Attr), so it's getting the
name field from that.

The typing is a bit odd as the attributes collection is currently a NamedNodeMap
when it should be just a map of Attrs, but it's sort of a byproduct of odd DOM
typing (NamedNodeMap is internal for Dart, but is going away in HTML5).

[Emily Fortuna, 2013-05-29 20:31:44]

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:23638: @deprecated // deprecated
On 2013/05/29 20:28:22, blois wrote:
> On 2013/05/29 20:20:43, Emily Fortuna wrote:
> > nit, but why have the comment that says the same thing?
> 
> This is a byproduct of the generation of the annotations from the metadata,
they
> were added for the initial review that you and Jacob did. I need to remove
them
> for the next step of metadata (not there yet).

I remember. It's just a little odd in this case. Not really a big deal, though.

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:24890: keys.add(attributes[i].name);
On 2013/05/29 20:28:22, blois wrote:
> On 2013/05/29 20:20:43, Emily Fortuna wrote:
> > I don't understand this change. I don't see a "name" field at all?
> 
> This is iterating through the attributes (type is Attr), so it's getting the
> name field from that.
> 
> The typing is a bit odd as the attributes collection is currently a
NamedNodeMap
> when it should be just a map of Attrs, but it's sort of a byproduct of odd DOM
> typing (NamedNodeMap is internal for Dart, but is going away in HTML5).

I get that, but I don't see the name field here in the Attr class:
http://api.dartlang.org/docs/bleeding_edge/dart_html/Attr.html  Am I missing
something?

[blois, 2013-05-29 21:42:06]

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:24890: keys.add(attributes[i].name);
On 2013/05/29 20:31:44, Emily Fortuna wrote:
> On 2013/05/29 20:28:22, blois wrote:
> > On 2013/05/29 20:20:43, Emily Fortuna wrote:
> > > I don't understand this change. I don't see a "name" field at all?
> > 
> > This is iterating through the attributes (type is Attr), so it's getting the
> > name field from that.
> > 
> > The typing is a bit odd as the attributes collection is currently a
> NamedNodeMap
> > when it should be just a map of Attrs, but it's sort of a byproduct of odd
DOM
> > typing (NamedNodeMap is internal for Dart, but is going away in HTML5).
> 
> I get that, but I don't see the name field here in the Attr class:
> http://api.dartlang.org/docs/bleeding_edge/dart_html/Attr.html  Am I missing
> something?

Yep, the change section preceeding this one in this file, which exposes the name
field :)

[Emily Fortuna, 2013-05-29 22:27:43]

lgtm

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/15814008/diff/2001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:24890: keys.add(attributes[i].name);
On 2013/05/29 21:42:06, blois wrote:
> On 2013/05/29 20:31:44, Emily Fortuna wrote:
> > On 2013/05/29 20:28:22, blois wrote:
> > > On 2013/05/29 20:20:43, Emily Fortuna wrote:
> > > > I don't understand this change. I don't see a "name" field at all?
> > > 
> > > This is iterating through the attributes (type is Attr), so it's getting
the
> > > name field from that.
> > > 
> > > The typing is a bit odd as the attributes collection is currently a
> > NamedNodeMap
> > > when it should be just a map of Attrs, but it's sort of a byproduct of odd
> DOM
> > > typing (NamedNodeMap is internal for Dart, but is going away in HTML5).
> > 
> > I get that, but I don't see the name field here in the Attr class:
> > http://api.dartlang.org/docs/bleeding_edge/dart_html/Attr.html  Am I missing
> > something?
> 
> Yep, the change section preceeding this one in this file, which exposes the
name
> field :)

(facepalm) Duh!

[blois, 2013-05-30 16:31:16]

Committed patchset #1 manually as r23423 (presubmit successful).