Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed.

sdk/lib/html/dart2js/html_dart2js.dart

 /// The Dart HTML library.
 library dart.dom.html;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_collection-dev' hide Symbol;
 import 'dart:html_common';
 import 'dart:indexed_db';
 import 'dart:isolate';
 import 'dart:json' as json;
@@ skipping 409 matching lines @@
   @DomName('HTMLAreaElement.target')
   @DocsEditable
   String target;
 }
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DocsEditable
-@DomName('Attr')
-class Attr extends Node native "Attr" {
-}
-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-
-@DocsEditable
 @DomName('HTMLAudioElement')
 class AudioElement extends MediaElement native "HTMLAudioElement" {
 
   @DomName('HTMLAudioElement.HTMLAudioElement')
   @DocsEditable
   factory AudioElement([String src]) {
     if (?src) {
       return AudioElement._create_1(src);
     }
     return AudioElement._create_2();
@@ skipping 7186 matching lines @@
    * [x-tags]: http://x-tags.org/
    */
   // Note: return type is `dynamic` for convenience to suppress warnings when
   // members of the component are used. The actual type is a subtype of Element.
   get xtag => _xtag != null ? _xtag : this;
 
   void set xtag(Element value) {
     _xtag = value;
   }
 
+  @DomName('Element.localName')
+  @DocsEditable
+  String get localName => $dom_localName;
+
+  @DomName('Element.namespaceUri')
+  @DocsEditable
+  String get namespaceUri => $dom_namespaceUri;
+
+  String toString() => localName;
+
   /**
    * Scrolls this element into view.
    *
    * Only one of of the alignment options may be specified at a time.
    *
    * If no options are specified then this will attempt to scroll the minimum
    * amount needed to bring the element into view.
    *
    * Note that alignCenter is currently only supported on WebKit platforms. If
    * alignCenter is specified but not supported then this will fall back to
@@ skipping 34 matching lines @@
       return 'wheel';
     } else if (JS('bool', '#.onmousewheel !== undefined', e)) {
       // Chrome & IE
       return 'mousewheel';
     } else {
       // Firefox
       return 'DOMMouseScroll';
     }
   }
 
-  @DomName('Element.webkitTransitionEndEvent')
+  @DomName('Element.transitionEndEvent')
   static const EventStreamProvider<TransitionEvent> transitionEndEvent =
       const _CustomEventStreamProvider<TransitionEvent>(
         Element._determineTransitionEventType);
 
   static String _determineTransitionEventType(EventTarget e) {
     // Unfortunately the normal 'ontransitionend' style checks don't work here.
     if (Device.isWebKit) {
       return 'webkitTransitionEnd';
     } else if (Device.isOpera) {
       return 'oTransitionEnd';
@@ skipping 1137 matching lines @@
   // http://www.w3.org/TR/touch-events/, http://www.chromestatus.com/features
   @Experimental
   Stream<TouchEvent> get onTouchMove => touchMoveEvent.forTarget(this);
 
   @DomName('Element.ontouchstart')
   @DocsEditable
   // http://www.w3.org/TR/touch-events/, http://www.chromestatus.com/features
   @Experimental
   Stream<TouchEvent> get onTouchStart => touchStartEvent.forTarget(this);
 
-  @DomName('Element.onwebkitTransitionEnd')
+  @DomName('Element.ontransitionend')
   @DocsEditable
   @SupportedBrowser(SupportedBrowser.CHROME)
   @SupportedBrowser(SupportedBrowser.FIREFOX)
   @SupportedBrowser(SupportedBrowser.IE, '10')
   @SupportedBrowser(SupportedBrowser.SAFARI)
-  @deprecated
   Stream<TransitionEvent> get onTransitionEnd => transitionEndEvent.forTarget(this);
 
   @DomName('Element.onwebkitfullscreenchange')
   @DocsEditable
   // https://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
   @Experimental
   Stream<Event> get onFullscreenChange => fullscreenChangeEvent.forTarget(this);
 
   @DomName('Element.onwebkitfullscreenerror')
   @DocsEditable
@@ skipping 6948 matching lines @@
     } else {
       for (var node in newNodes) {
         this.insertBefore(node, refChild);
       }
     }
   }
 
   /**
    * Print out a String representation of this Node.
    */
-  String toString() => localName == null ?
-      (nodeValue == null ? super.toString() : nodeValue) : localName;
+  String toString() => nodeValue == null ? super.toString() : nodeValue;
 
   /**
    * Binds the attribute [name] to the [path] of the [model].
    * Path is a String of accessors such as `foo.bar.baz`.
    */
   @Experimental
   void bind(String name, model, String path) {
     // TODO(jmesserly): should we throw instead?
     window.console.error('Unhandled binding to Node: '
         '$this $name $model $path');
@@ skipping 74 matching lines @@
   @JSName('firstChild')
   @DomName('Node.firstChild')
   @DocsEditable
   final Node $dom_firstChild;
 
   @JSName('lastChild')
   @DomName('Node.lastChild')
   @DocsEditable
   final Node $dom_lastChild;
 
+  @JSName('localName')
   @DomName('Node.localName')
   @DocsEditable
   // http://dom.spec.whatwg.org/#dom-node-localname
   @deprecated // deprecated
-  final String localName;
+  final String $dom_localName;
 
   @JSName('namespaceURI')
   @DomName('Node.namespaceURI')
   @DocsEditable
   // http://dom.spec.whatwg.org/#dom-node-namespaceuri
   @deprecated // deprecated
   final String $dom_namespaceUri;
 
   @JSName('nextSibling')
   @DomName('Node.nextSibling')
@@ skipping 7270 matching lines @@
   // http://www.w3.org/TR/touch-events/, http://www.chromestatus.com/features
   @Experimental
   Stream<TouchEvent> get onTouchMove => Element.touchMoveEvent.forTarget(this);
 
   @DomName('Window.ontouchstart')
   @DocsEditable
   // http://www.w3.org/TR/touch-events/, http://www.chromestatus.com/features
   @Experimental
   Stream<TouchEvent> get onTouchStart => Element.touchStartEvent.forTarget(this);
 
+  @DomName('Window.ontransitionend')
+  @DocsEditable
+  Stream<TransitionEvent> get onTransitionEnd => Element.transitionEndEvent.forTarget(this);
+
   @DomName('Window.onunload')
   @DocsEditable
   Stream<Event> get onUnload => unloadEvent.forTarget(this);
 
   @DomName('Window.onwebkitAnimationEnd')
   @DocsEditable
   @Experimental // untriaged
   Stream<AnimationEvent> get onAnimationEnd => animationEndEvent.forTarget(this);
 
   @DomName('Window.onwebkitAnimationIteration')
   @DocsEditable
   @Experimental // untriaged
   Stream<AnimationEvent> get onAnimationIteration => animationIterationEvent.forTarget(this);
 
   @DomName('Window.onwebkitAnimationStart')
   @DocsEditable
   @Experimental // untriaged
   Stream<AnimationEvent> get onAnimationStart => animationStartEvent.forTarget(this);
 
-  @DomName('Window.onwebkitTransitionEnd')
-  @DocsEditable
-  @deprecated
-  Stream<TransitionEvent> get onTransitionEnd => Element.transitionEndEvent.forTarget(this);
-
 
   @DomName('DOMWindow.beforeunloadEvent')
   @DocsEditable
   static const EventStreamProvider<BeforeUnloadEvent> beforeUnloadEvent =
       const _BeforeUnloadEventStreamProvider('beforeunload');
 
   @DomName('DOMWindow.onbeforeunload')
   @DocsEditable
   Stream<Event> get onBeforeUnload => beforeUnloadEvent.forTarget(this);
 }
@@ skipping 354 matching lines @@
   @DomName('XSLTProcessor.transformToFragment')
   @DocsEditable
   DocumentFragment transformToFragment(Node source, Document docVal) native;
 }
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 @DocsEditable
+@DomName('Attr')
+class _Attr extends Node native "Attr" {
+
+  @DomName('Attr.isId')
+  @DocsEditable
+  final bool isId;
+
+  @DomName('Attr.name')
+  @DocsEditable
+  final String name;
+
+  @DomName('Attr.ownerElement')
+  @DocsEditable
+  @deprecated // deprecated
+  final Element ownerElement;
+
+  @DomName('Attr.specified')
+  @DocsEditable
+  @deprecated // deprecated

[Emily Fortuna, 2013/05/29 20:20:43]

nit, but why have the comment that says the same thing?

[blois, 2013/05/29 20:28:22]

This is a byproduct of the generation of the annotations from the metadata, they
were added for the initial review that you and Jacob did. I need to remove them
for the next step of metadata (not there yet).

[Emily Fortuna, 2013/05/29 20:31:44]

I remember. It's just a little odd in this case. Not really a big deal, though.

+  final bool specified;
+
+  @DomName('Attr.value')
+  @DocsEditable
+  String value;
+}
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+
+@DocsEditable
 @DomName('CSSPrimitiveValue')
 // http://dev.w3.org/csswg/cssom/#the-cssstyledeclaration-interface
 @deprecated // deprecated
 abstract class _CSSPrimitiveValue extends _CSSValue native "CSSPrimitiveValue" {
 }
 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
@@ skipping 1219 matching lines @@
       f(key, value);
     }
   }
 
   Iterable<String> get keys {
     // TODO: generate a lazy collection instead.
     var attributes = _element.$dom_attributes;
     var keys = new List<String>();
     for (int i = 0, len = attributes.length; i < len; i++) {
       if (_matches(attributes[i])) {
-        keys.add(attributes[i].localName);
+        keys.add(attributes[i].name);

[Emily Fortuna, 2013/05/29 20:20:43]

I don't understand this change. I don't see a "name" field at all?

[blois, 2013/05/29 20:28:22]

This is iterating through the attributes (type is Attr), so it's getting the
name field from that.

The typing is a bit odd as the attributes collection is currently a NamedNodeMap
when it should be just a map of Attrs, but it's sort of a byproduct of odd DOM
typing (NamedNodeMap is internal for Dart, but is going away in HTML5).

[Emily Fortuna, 2013/05/29 20:31:44]

I get that, but I don't see the name field here in the Attr class:
http://api.dartlang.org/docs/bleeding_edge/dart_html/Attr.html  Am I missing
something?

[blois, 2013/05/29 21:42:06]

Yep, the change section preceeding this one in this file, which exposes the name
field :)

[Emily Fortuna, 2013/05/29 22:27:43]

(facepalm) Duh!

       }
     }
     return keys;
   }
 
   Iterable<String> get values {
     // TODO: generate a lazy collection instead.
     var attributes = _element.$dom_attributes;
     var values = new List<String>();
     for (int i = 0, len = attributes.length; i < len; i++) {
@@ skipping 4427 matching lines @@
       _position = nextPosition;
       return true;
     }
     _current = null;
     _position = _array.length;
     return false;
   }
 
   T get current => _current;
 }