Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 15814008: Cleaning up some DOM APIs which were marked as deprecated because they were moved or renamed. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 021a3ca53e198019a839085e18344c8c674afc6c..4c85231f986fce9fd73af97975262c912a8f5801 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -427,15 +427,6 @@ class AreaElement extends Element native "HTMLAreaElement" {
@DocsEditable
-@DomName('Attr')
-class Attr extends Node native "Attr" {
-}
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-
-@DocsEditable
@DomName('HTMLAudioElement')
class AudioElement extends MediaElement native "HTMLAudioElement" {
@@ -7642,6 +7633,16 @@ abstract class Element extends Node implements ElementTraversal native "Element"
_xtag = value;
}
+ @DomName('Element.localName')
+ @DocsEditable
+ String get localName => $dom_localName;
+
+ @DomName('Element.namespaceUri')
+ @DocsEditable
+ String get namespaceUri => $dom_namespaceUri;
+
+ String toString() => localName;
+
/**
* Scrolls this element into view.
*
@@ -7696,7 +7697,7 @@ abstract class Element extends Node implements ElementTraversal native "Element"
}
}
- @DomName('Element.webkitTransitionEndEvent')
+ @DomName('Element.transitionEndEvent')
static const EventStreamProvider<TransitionEvent> transitionEndEvent =
const _CustomEventStreamProvider<TransitionEvent>(
Element._determineTransitionEventType);
@@ -8854,13 +8855,12 @@ abstract class Element extends Node implements ElementTraversal native "Element"
@Experimental
Stream<TouchEvent> get onTouchStart => touchStartEvent.forTarget(this);
- @DomName('Element.onwebkitTransitionEnd')
+ @DomName('Element.ontransitionend')
@DocsEditable
@SupportedBrowser(SupportedBrowser.CHROME)
@SupportedBrowser(SupportedBrowser.FIREFOX)
@SupportedBrowser(SupportedBrowser.IE, '10')
@SupportedBrowser(SupportedBrowser.SAFARI)
- @deprecated
Stream<TransitionEvent> get onTransitionEnd => transitionEndEvent.forTarget(this);
@DomName('Element.onwebkitfullscreenchange')
@@ -15829,8 +15829,7 @@ class Node extends EventTarget native "Node" {
/**
* Print out a String representation of this Node.
*/
- String toString() => localName == null ?
- (nodeValue == null ? super.toString() : nodeValue) : localName;
+ String toString() => nodeValue == null ? super.toString() : nodeValue;
/**
* Binds the attribute [name] to the [path] of the [model].
@@ -15925,11 +15924,12 @@ class Node extends EventTarget native "Node" {
@DocsEditable
final Node $dom_lastChild;
+ @JSName('localName')
@DomName('Node.localName')
@DocsEditable
// http://dom.spec.whatwg.org/#dom-node-localname
@deprecated // deprecated
- final String localName;
+ final String $dom_localName;
@JSName('namespaceURI')
@DomName('Node.namespaceURI')
@@ -23220,6 +23220,10 @@ class Window extends EventTarget implements WindowBase native "Window,DOMWindow"
@Experimental
Stream<TouchEvent> get onTouchStart => Element.touchStartEvent.forTarget(this);
+ @DomName('Window.ontransitionend')
+ @DocsEditable
+ Stream<TransitionEvent> get onTransitionEnd => Element.transitionEndEvent.forTarget(this);
+
@DomName('Window.onunload')
@DocsEditable
Stream<Event> get onUnload => unloadEvent.forTarget(this);
@@ -23239,11 +23243,6 @@ class Window extends EventTarget implements WindowBase native "Window,DOMWindow"
@Experimental // untriaged
Stream<AnimationEvent> get onAnimationStart => animationStartEvent.forTarget(this);
- @DomName('Window.onwebkitTransitionEnd')
- @DocsEditable
- @deprecated
- Stream<TransitionEvent> get onTransitionEnd => Element.transitionEndEvent.forTarget(this);
-
@DomName('DOMWindow.beforeunloadEvent')
@DocsEditable
@@ -23618,6 +23617,37 @@ class XsltProcessor native "XSLTProcessor" {
@DocsEditable
+@DomName('Attr')
+class _Attr extends Node native "Attr" {
+
+ @DomName('Attr.isId')
+ @DocsEditable
+ final bool isId;
+
+ @DomName('Attr.name')
+ @DocsEditable
+ final String name;
+
+ @DomName('Attr.ownerElement')
+ @DocsEditable
+ @deprecated // deprecated
+ final Element ownerElement;
+
+ @DomName('Attr.specified')
+ @DocsEditable
+ @deprecated // deprecated
Emily Fortuna 2013/05/29 20:20:43 nit, but why have the comment that says the same t
blois 2013/05/29 20:28:22 This is a byproduct of the generation of the annot
Emily Fortuna 2013/05/29 20:31:44 I remember. It's just a little odd in this case. N
+ final bool specified;
+
+ @DomName('Attr.value')
+ @DocsEditable
+ String value;
+}
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+
+@DocsEditable
@DomName('CSSPrimitiveValue')
// http://dev.w3.org/csswg/cssom/#the-cssstyledeclaration-interface
@deprecated // deprecated
@@ -24857,7 +24887,7 @@ abstract class _AttributeMap implements Map<String, String> {
var keys = new List<String>();
for (int i = 0, len = attributes.length; i < len; i++) {
if (_matches(attributes[i])) {
- keys.add(attributes[i].localName);
+ keys.add(attributes[i].name);
Emily Fortuna 2013/05/29 20:20:43 I don't understand this change. I don't see a "nam
blois 2013/05/29 20:28:22 This is iterating through the attributes (type is
Emily Fortuna 2013/05/29 20:31:44 I get that, but I don't see the name field here in
blois 2013/05/29 21:42:06 Yep, the change section preceeding this one in thi
Emily Fortuna 2013/05/29 22:27:43 (facepalm) Duh!
}
}
return keys;
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698