Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger.

Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger.

Rather than by ad-hoc checks at the point of return.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23151

[Ivan Posva, 2013-05-23 21:37:53]

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:262: return big.AsValidInteger();
Aren't these here redundant as the result will be passed through AsValidInteger?
Alternatively you could just do this in the native entries:

return ShiftOperationsHelper(Token::XXXX, value, amount);

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:313: 
Two lines!

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc
File runtime/lib/typed_data.cc (right):

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:113: 
ditto

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:259: const Bigint& result =                           
                           \
This instance feels like it would be better served with a new Integer
construction such as Integer::NewFromUint64(value), don't you think?

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:405: const Bigint& result =
Bigint::Handle(BigintOperations::NewFromUint64(value));
ditto

[zra, 2013-05-23 22:14:38]

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc
File runtime/lib/integers.cc (right):

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:262: return big.AsValidInteger();
On 2013/05/23 21:37:54, Ivan Posva wrote:
> Aren't these here redundant as the result will be passed through
AsValidInteger?
> Alternatively you could just do this in the native entries:
> 
> return ShiftOperationsHelper(Token::XXXX, value, amount);

You're right. I've removed the changes here.

https://codereview.chromium.org/15741019/diff/1/runtime/lib/integers.cc#newco...
runtime/lib/integers.cc:313: 
On 2013/05/23 21:37:54, Ivan Posva wrote:
> Two lines!

There are two lines between the bottom of the function and the comment. Is that
not right?

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc
File runtime/lib/typed_data.cc (right):

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:113: 
On 2013/05/23 21:37:54, Ivan Posva wrote:
> ditto

Not sure what this is dittoing.

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:259: const Bigint& result =                           
                           \
On 2013/05/23 21:37:54, Ivan Posva wrote:
> This instance feels like it would be better served with a new Integer
> construction such as Integer::NewFromUint64(value), don't you think?

Done.

https://codereview.chromium.org/15741019/diff/1/runtime/lib/typed_data.cc#new...
runtime/lib/typed_data.cc:405: const Bigint& result =
Bigint::Handle(BigintOperations::NewFromUint64(value));
On 2013/05/23 21:37:54, Ivan Posva wrote:
> ditto

Done.

[Ivan Posva, 2013-05-23 22:37:31]

LGTM -ip

[zra, 2013-05-24 15:45:22]

Committed patchset #4 manually as r23151 (presubmit successful).