Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger.

runtime/lib/integers.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
@@ skipping 238 matching lines @@
       }
     } else {
       // Overflow in shift, use Bigints
       big_value = BigintOperations::NewFromInt64(mint_value);
     }
   } else {
     ASSERT(value.IsBigint());
     big_value = Bigint::Cast(value).raw();
   }
   switch (kind) {
-    case Token::kSHL:
-      return BigintOperations::ShiftLeft(big_value, amount.Value());
-    case Token::kSHR:
-      return BigintOperations::ShiftRight(big_value, amount.Value());
+    case Token::kSHL: {
+      const Bigint& big = Bigint::Handle(
+          BigintOperations::ShiftLeft(big_value, amount.Value()));
+      return big.AsValidInteger();

[Ivan Posva, 2013/05/23 21:37:54]

Aren't these here redundant as the result will be passed through AsValidInteger?
Alternatively you could just do this in the native entries:

return ShiftOperationsHelper(Token::XXXX, value, amount);

[zra, 2013/05/23 22:14:38]

You're right. I've removed the changes here.

+    }
+    case Token::kSHR: {
+      const Bigint& big = Bigint::Handle(
+          BigintOperations::ShiftRight(big_value, amount.Value()));
+      return big.AsValidInteger();
+    }
     default:
       UNIMPLEMENTED();
   }
   return Integer::null();
 }
 
 
 DEFINE_NATIVE_ENTRY(Smi_shrFromInt, 2) {
   const Smi& amount = Smi::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, value, arguments->NativeArgAt(1));
@@ skipping 24 matching lines @@
 DEFINE_NATIVE_ENTRY(Smi_bitNegate, 1) {
   const Smi& operand = Smi::CheckedHandle(arguments->NativeArgAt(0));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Smi_bitNegate: %s\n", operand.ToCString());
   }
   intptr_t result = ~operand.Value();
   ASSERT(Smi::IsValid(result));
   return Smi::New(result);
 }
 
+

[Ivan Posva, 2013/05/23 21:37:54]

Two lines!

[zra, 2013/05/23 22:14:38]

There are two lines between the bottom of the function and the comment. Is that
not right?

 // Mint natives.
 
 DEFINE_NATIVE_ENTRY(Mint_bitNegate, 1) {
   const Mint& operand = Mint::CheckedHandle(arguments->NativeArgAt(0));
   ASSERT(CheckInteger(operand));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Mint_bitNegate: %s\n", operand.ToCString());
   }
   int64_t result = ~operand.value();
   return Integer::New(result);
 }
 
+
 // Bigint natives.
 
 DEFINE_NATIVE_ENTRY(Bigint_bitNegate, 1) {
   const Bigint& value = Bigint::CheckedHandle(arguments->NativeArgAt(0));
   const Bigint& result = Bigint::Handle(BigintOperations::BitNot(value));
   ASSERT(CheckInteger(value));
   ASSERT(CheckInteger(result));
   return result.AsValidInteger();
 }
 
 }  // namespace dart