Ensures that Bigints returned to Dart are all checked by Integer::AsValidInteger.

runtime/lib/typed_data.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
@@ skipping 92 matching lines @@
   SetRangeCheck(dst_offset_in_bytes,
                 length_in_bytes,
                 dst_array.LengthInBytes(),
                 element_size_in_bytes);
   TypedData::Copy<DstType, SrcType>(dst_array, dst_offset_in_bytes,
                                     src_array, src_offset_in_bytes,
                                     length_in_bytes);
   return Bool::True().raw();
 }
 
+

[Ivan Posva, 2013/05/23 21:37:54]

ditto

[zra, 2013/05/23 22:14:38]

Not sure what this is dittoing.

 DEFINE_NATIVE_ENTRY(TypedData_setRange, 5) {
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, dst, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, dst_start, arguments->NativeArgAt(1));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(2));
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, src, arguments->NativeArgAt(3));
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, src_start, arguments->NativeArgAt(4));
 
   if (length.Value() < 0) {
     const String& error = String::Handle(String::NewFormatted(
         "length (%"Pd") must be non-negative", length.Value()));
@@ skipping 125 matching lines @@
     const ExternalTypedData& array = ExternalTypedData::Cast(instance);        \
     ASSERT(RangeCheck(offsetInBytes.Value(), array.LengthInBytes()));          \
     value = array.getter(offsetInBytes.Value());                               \
   } else {                                                                     \
     const String& error = String::Handle(String::NewFormatted(                 \
         "Expected a TypedData object but found %s", instance.ToCString()));    \
     const Array& args = Array::Handle(Array::New(1));                          \
     args.SetAt(0, error);                                                      \
     Exceptions::ThrowByType(Exceptions::kArgument, args);                      \
   }                                                                            \
-  Integer& result = Integer::Handle();                                         \
-  if (value > static_cast<uint64_t>(Mint::kMaxValue)) {                        \
-    result = BigintOperations::NewFromUint64(value);                           \
-  } else {                                                                     \
-    result = Integer::New(value);                                              \
-  }                                                                            \
-  return result.raw();                                                         \
+  const Bigint& result =                                                       \

[Ivan Posva, 2013/05/23 21:37:54]

This instance feels like it would be better served with a new Integer
construction such as Integer::NewFromUint64(value), don't you think?

[zra, 2013/05/23 22:14:38]

Done.

+      Bigint::Handle(BigintOperations::NewFromUint64(value));                  \
+  return result.AsValidInteger();                                              \
 }                                                                              \
 
 
 // TODO(asiva): Consider truncating the bigint value if it does not fit into
 // a uint64_t value (see ASSERT(BigintOperations::FitsIntoUint64(bigint))).
 #define TYPED_DATA_UINT64_SETTER(setter, object)                               \
 DEFINE_NATIVE_ENTRY(TypedData_##setter, 3) {                                   \
   GET_NON_NULL_NATIVE_ARGUMENT(Instance, instance, arguments->NativeArgAt(0)); \
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, offsetInBytes, arguments->NativeArgAt(1)); \
   GET_NON_NULL_NATIVE_ARGUMENT(object, value, arguments->NativeArgAt(2));      \
@@ skipping 123 matching lines @@
     value = BigintOperations::AbsToUint64(bigint);
   } else {
     ASSERT(host_value.IsMint() || host_value.IsSmi());
     value = host_value.AsInt64Value();
   }
   if (little_endian.value()) {
     value = Utils::HostToLittleEndian64(value);
   } else {
     value = Utils::HostToBigEndian64(value);
   }
-  if (value > static_cast<uint64_t>(Mint::kMaxValue)) {
-    return BigintOperations::NewFromUint64(value);
-  }
-  return Integer::New(value);
+  const Bigint& result = Bigint::Handle(BigintOperations::NewFromUint64(value));

[Ivan Posva, 2013/05/23 21:37:54]

ditto

[zra, 2013/05/23 22:14:38]

Done.

+  return result.AsValidInteger();
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteData_ToEndianFloat32, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(Double, host_value, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Bool, little_endian, arguments->NativeArgAt(1));
   float value = host_value.value();
   if (little_endian.value()) {
     value = bit_cast<float>(
         Utils::HostToLittleEndian32(bit_cast<uint32_t>(value)));
@@ skipping 13 matching lines @@
     value = bit_cast<double>(
         Utils::HostToLittleEndian64(bit_cast<uint64_t>(value)));
   } else {
     value = bit_cast<double>(
         Utils::HostToBigEndian64(bit_cast<uint64_t>(value)));
   }
   return Double::New(value);
 }
 
 }  // namespace dart