Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15741017: Issue 8365. Report error when user library imports an internal SDK library. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -19 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/ImportElement.java View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ImportElementImpl.java View 3 chunks +19 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/ImportElementHandle.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/Library.java View 5 chunks +20 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java View 1 chunk +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java View 3 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/sdk/SdkLibraryImpl.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 5 chunks +59 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DartSdk.java View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java View 2 chunks +6 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/SdkLibrary.java View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdkManager.java View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 7 months ago (2013-05-23 18:09:58 UTC) #1
jwren
On 2013/05/23 18:09:58, scheglov wrote: LGTM
7 years, 7 months ago (2013-05-23 18:24:47 UTC) #2
Brian Wilkerson
LGTM. Do we need to do the same for export directives?
7 years, 7 months ago (2013-05-23 20:21:50 UTC) #3
scheglov
On 2013/05/23 20:21:50, Brian Wilkerson wrote: > LGTM. Do we need to do the same ...
7 years, 7 months ago (2013-05-23 20:52:43 UTC) #4
scheglov
7 years, 7 months ago (2013-05-23 20:59:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r23104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698