editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java - Issue 15741017: Issue 8365. Report error when user library imports an internal SDK library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

Issue 15741017: Issue 8365. Report error when user library imports an internal SDK library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DartSdk.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/SdkLibrary.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

index df387bddb07106318e6557ce264311a490a26ea7..908f43f4da7abaebe7c5c1745773ff57d2422a11 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DirectoryBasedDartSdk.java

@@ -294,6 +294,11 @@ public class DirectoryBasedDartSdk implements DartSdk {

return libraryMap.getSdkLibraries();

}

+ @Override

+ public SdkLibrary getSdkLibrary(String dartUri) {

+ return libraryMap.getLibrary(dartUri);

+ }

/**

* Return the revision number of this SDK, or {@code "0"} if the revision number cannot be

* discovered.

@@ -366,7 +371,7 @@ public class DirectoryBasedDartSdk implements DartSdk {

@Override

public Source mapDartUri(ContentCache contentCache, String dartUri) {

- SdkLibrary library = libraryMap.getLibrary(dartUri);

+ SdkLibrary library = getSdkLibrary(dartUri);

if (library == null) {

return null;

}