editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java - Issue 15741017: Issue 8365. Report error when user library imports an internal SDK library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java

Issue 15741017: Issue 8365. Report error when user library imports an internal SDK library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/Library.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java

index 39f173bc0864236b69cdcf894c8bc2ae754f5b7e..dc7666b639ceda050725c62af853811bc782374f 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryElementBuilder.java

@@ -105,8 +105,9 @@ public class LibraryElementBuilder {

directivesToResolve.add(directive);

}

} else if (directive instanceof PartDirective) {

- StringLiteral partUri = ((PartDirective) directive).getUri();

- Source partSource = library.getSource(partUri);

+ PartDirective partDirective = (PartDirective) directive;

+ StringLiteral partUri = partDirective.getUri();

+ Source partSource = library.getSource(partDirective);

if (partSource != null && partSource.exists()) {

hasPartDirective = true;

CompilationUnitElementImpl part = builder.buildCompilationUnit(