Issue 15712007: Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the …

Issue 15712007: Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the … (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the actual element that would be hit at runtime. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23259

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -19 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1	2 chunks	+12 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart	View	1	4 chunks	+12 lines, -9 lines	0 comments	Download
A	tests/language/super_abstract_method_test.dart	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/15712007/diff/1/tests/language/super_abstract_method_test.dart File tests/language/super_abstract_method_test.dart (right): https://codereview.chromium.org/15712007/diff/1/tests/language/super_abstract_method_test.dart#newcode23 tests/language/super_abstract_method_test.dart:23: Expect.equals(42 ,new B().foo()); Space after comma, not before.

7 years, 6 months ago (2013-05-28 12:23:32 UTC) #2

ngeoffray

Thanks Karl. https://codereview.chromium.org/15712007/diff/1/tests/language/super_abstract_method_test.dart File tests/language/super_abstract_method_test.dart (right): https://codereview.chromium.org/15712007/diff/1/tests/language/super_abstract_method_test.dart#newcode23 tests/language/super_abstract_method_test.dart:23: Expect.equals(42 ,new B().foo()); On 2013/05/28 12:23:32, karlklose ...

7 years, 6 months ago (2013-05-28 12:25:32 UTC) #3

ngeoffray

7 years, 6 months ago (2013-05-28 12:45:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23259 (presubmit successful).

Expand Messages | Collapse Messages