Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the …

sdk/lib/_internal/compiler/implementation/elements/modelx.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library elements.modelx;
 
 import 'dart:uri';
 import 'dart:collection' show LinkedHashMap;
 
 import 'elements.dart';
@@ skipping 1564 matching lines @@
   /**
    * Find the first member in the class chain with the given [selector].
    *
    * This method is NOT to be used for resolving
    * unqualified sends because it does not implement the scoping
    * rules, where library scope comes before superclass scope.
    *
    * When called on the implementation element both members declared in the
    * origin and the patch class are returned.
    */
-  Element lookupSelector(Selector selector) {
-    return internalLookupSelector(selector, false);
+  Element lookupSelector(Selector selector, Compiler compiler) {
+    return internalLookupSelector(selector, compiler, false);
   }
 
-  Element lookupSuperSelector(Selector selector) {
-    return internalLookupSelector(selector, true);
+  Element lookupSuperSelector(Selector selector, Compiler compiler) {
+    return internalLookupSelector(selector, compiler, true);
   }
 
-  Element internalLookupSelector(Selector selector, bool isSuperLookup) {
+  Element internalLookupSelector(Selector selector,
+                                 Compiler compiler,
+                                 bool isSuperLookup) {
     SourceString name = selector.name;
     bool isPrivate = name.isPrivate();
     LibraryElement library = selector.library;
     for (ClassElement current = isSuperLookup ? superclass : this;
          current != null;
          current = current.superclass) {
       Element member = current.lookupLocalMember(name);
       if (member == null && current.isPatched) {
         // Doing lookups on selectors is done after resolution, so it
         // is safe to look in the patch class.
         member = current.patch.lookupLocalMember(name);
       }
       if (member == null) continue;
       // Private members from a different library are not visible.
       if (isPrivate && !identical(library, member.getLibrary())) continue;
       // Static members are not inherited.
       if (member.modifiers.isStatic() && !identical(this, current)) continue;
       // If we find an abstract field we have to make sure that it has
       // the getter or setter part we're actually looking
       // for. Otherwise, we continue up the superclass chain.
       if (member.isAbstractField()) {
         AbstractFieldElement field = member;
         FunctionElement getter = field.getter;
         FunctionElement setter = field.setter;
         if (selector.isSetter()) {
-          if (setter != null) return setter;
+          // Abstract members can be defined in a super class.
+          if (setter != null && !setter.isAbstract(compiler)) return setter;
         } else {
           assert(selector.isGetter() || selector.isCall());
-          if (getter != null) return getter;
+          if (getter != null && !getter.isAbstract(compiler)) return getter;
         }
-      } else {
+      // Abstract members can be defined in a super class.
+      } else if (!member.isAbstract(compiler)) {
         return member;
       }
     }
     return null;
   }
 
   /**
    * Find the first member in the class chain with the given
    * [memberName]. This method is NOT to be used for resolving
    * unqualified sends because it does not implement the scoping
@@ skipping 460 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }