sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 15712007: Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 15712007: Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/elements/modelx.dart ('k') | sdk/lib/_internal/compiler/implementation/types/flat_type_mask.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 23237)

+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)

@@ -2017,7 +2017,7 @@

}

// TODO(johnniwinther): Ensure correct behavior if currentClass is a

// patch.

- target = currentClass.lookupSuperSelector(selector);

+ target = currentClass.lookupSuperSelector(selector, compiler);

// [target] may be null which means invoking noSuchMethod on

// super.

if (target == null) {

@@ -2350,7 +2350,7 @@

registerSend(getterSelector, getter);

mapping.setGetterSelectorInComplexSendSet(node, getterSelector);

if (node.isSuperCall) {

- getter = currentClass.lookupSuperSelector(getterSelector);

+ getter = currentClass.lookupSuperSelector(getterSelector, compiler);

if (getter == null) {

target = warnAndCreateErroneousElement(

node, selector.name, MessageKind.NO_SUCH_SUPER_MEMBER,