Issue 15563007: Remove an unnecessary setter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15563007: Remove an unnecessary setter. (Closed)

Created:
7 years, 7 months ago by Kevin Millikin (Google)

Modified:
7 years, 7 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove an unnecessary setter. A field of the CompilerDeoptInfo had a setter that was always and only called immediately after construction. Instead, set it in the constructor. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22981

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -32 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	4 chunks	+11 lines, -9 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

I also changed the naming of deoptimization_env_ to be consistent with CompilerDeoptInfo and deopt_id_ in ...

7 years, 7 months ago (2013-05-21 13:40:37 UTC) #1

Florian Schneider

LGTM. https://codereview.chromium.org/15563007/diff/1/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://codereview.chromium.org/15563007/diff/1/runtime/vm/flow_graph_compiler.h#newcode143 runtime/vm/flow_graph_compiler.h:143: Environment* deopt_env_; Can you make this const as ...

7 years, 7 months ago (2013-05-21 13:47:11 UTC) #2

Kevin Millikin (Google)

7 years, 7 months ago (2013-05-22 06:21:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22981 (presubmit successful).

Expand Messages | Collapse Messages