Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 15563007: Remove an unnecessary setter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 30 matching lines...) Expand all
41 41
42 42
43 bool FlowGraphCompiler::SupportsUnboxedMints() { 43 bool FlowGraphCompiler::SupportsUnboxedMints() {
44 // Support unboxed mints when SSE 4.1 is available. 44 // Support unboxed mints when SSE 4.1 is available.
45 return FLAG_unbox_mints && CPUFeatures::sse4_1_supported(); 45 return FLAG_unbox_mints && CPUFeatures::sse4_1_supported();
46 } 46 }
47 47
48 48
49 RawDeoptInfo* CompilerDeoptInfo::CreateDeoptInfo(FlowGraphCompiler* compiler, 49 RawDeoptInfo* CompilerDeoptInfo::CreateDeoptInfo(FlowGraphCompiler* compiler,
50 DeoptInfoBuilder* builder) { 50 DeoptInfoBuilder* builder) {
51 if (deoptimization_env_ == NULL) return DeoptInfo::null(); 51 if (deopt_env_ == NULL) return DeoptInfo::null();
52 52
53 intptr_t stack_height = compiler->StackSize(); 53 intptr_t stack_height = compiler->StackSize();
54 AllocateIncomingParametersRecursive(deoptimization_env_, &stack_height); 54 AllocateIncomingParametersRecursive(deopt_env_, &stack_height);
55 55
56 intptr_t slot_ix = 0; 56 intptr_t slot_ix = 0;
57 Environment* current = deoptimization_env_; 57 Environment* current = deopt_env_;
58 58
59 // Emit all kMaterializeObject instructions describing objects to be 59 // Emit all kMaterializeObject instructions describing objects to be
60 // materialized on the deoptimization as a prefix to the deoptimization info. 60 // materialized on the deoptimization as a prefix to the deoptimization info.
61 EmitMaterializations(deoptimization_env_, builder); 61 EmitMaterializations(deopt_env_, builder);
62 62
63 // The real frame starts here. 63 // The real frame starts here.
64 builder->MarkFrameStart(); 64 builder->MarkFrameStart();
65 65
66 // Callee's PC marker is not used anymore. Pass Function::null() to set to 0. 66 // Callee's PC marker is not used anymore. Pass Function::null() to set to 0.
67 builder->AddPcMarker(Function::Handle(), slot_ix++); 67 builder->AddPcMarker(Function::Handle(), slot_ix++);
68 68
69 // Current FP and PC. 69 // Current FP and PC.
70 builder->AddCallerFp(slot_ix++); 70 builder->AddCallerFp(slot_ix++);
71 builder->AddReturnAddress(current->function(), 71 builder->AddReturnAddress(current->function(),
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler, 141 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler,
142 intptr_t stub_ix) { 142 intptr_t stub_ix) {
143 // Calls do not need stubs, they share a deoptimization trampoline. 143 // Calls do not need stubs, they share a deoptimization trampoline.
144 ASSERT(reason() != kDeoptAtCall); 144 ASSERT(reason() != kDeoptAtCall);
145 Assembler* assem = compiler->assembler(); 145 Assembler* assem = compiler->assembler();
146 #define __ assem-> 146 #define __ assem->
147 __ Comment("Deopt stub for id %"Pd"", deopt_id()); 147 __ Comment("Deopt stub for id %"Pd"", deopt_id());
148 __ Bind(entry_label()); 148 __ Bind(entry_label());
149 if (FLAG_trap_on_deoptimization) __ int3(); 149 if (FLAG_trap_on_deoptimization) __ int3();
150 150
151 ASSERT(deoptimization_env() != NULL); 151 ASSERT(deopt_env() != NULL);
152 152
153 __ call(&StubCode::DeoptimizeLabel()); 153 __ call(&StubCode::DeoptimizeLabel());
154 set_pc_offset(assem->CodeSize()); 154 set_pc_offset(assem->CodeSize());
155 __ int3(); 155 __ int3();
156 #undef __ 156 #undef __
157 } 157 }
158 158
159 159
160 #define __ assembler()-> 160 #define __ assembler()->
161 161
(...skipping 1790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1952 __ movups(reg, Address(ESP, 0)); 1952 __ movups(reg, Address(ESP, 0));
1953 __ addl(ESP, Immediate(kFpuRegisterSize)); 1953 __ addl(ESP, Immediate(kFpuRegisterSize));
1954 } 1954 }
1955 1955
1956 1956
1957 #undef __ 1957 #undef __
1958 1958
1959 } // namespace dart 1959 } // namespace dart
1960 1960
1961 #endif // defined TARGET_ARCH_IA32 1961 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698