Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 15563007: Remove an unnecessary setter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 28 matching lines...) Expand all
39 } 39 }
40 40
41 41
42 bool FlowGraphCompiler::SupportsUnboxedMints() { 42 bool FlowGraphCompiler::SupportsUnboxedMints() {
43 return false; 43 return false;
44 } 44 }
45 45
46 46
47 RawDeoptInfo* CompilerDeoptInfo::CreateDeoptInfo(FlowGraphCompiler* compiler, 47 RawDeoptInfo* CompilerDeoptInfo::CreateDeoptInfo(FlowGraphCompiler* compiler,
48 DeoptInfoBuilder* builder) { 48 DeoptInfoBuilder* builder) {
49 if (deoptimization_env_ == NULL) return DeoptInfo::null(); 49 if (deopt_env_ == NULL) return DeoptInfo::null();
50 50
51 intptr_t stack_height = compiler->StackSize(); 51 intptr_t stack_height = compiler->StackSize();
52 AllocateIncomingParametersRecursive(deoptimization_env_, &stack_height); 52 AllocateIncomingParametersRecursive(deopt_env_, &stack_height);
53 53
54 intptr_t slot_ix = 0; 54 intptr_t slot_ix = 0;
55 Environment* current = deoptimization_env_; 55 Environment* current = deopt_env_;
56 56
57 // Emit all kMaterializeObject instructions describing objects to be 57 // Emit all kMaterializeObject instructions describing objects to be
58 // materialized on the deoptimization as a prefix to the deoptimization info. 58 // materialized on the deoptimization as a prefix to the deoptimization info.
59 EmitMaterializations(deoptimization_env_, builder); 59 EmitMaterializations(deopt_env_, builder);
60 60
61 // The real frame starts here. 61 // The real frame starts here.
62 builder->MarkFrameStart(); 62 builder->MarkFrameStart();
63 63
64 // Callee's PC marker is not used anymore. Pass Function::null() to set to 0. 64 // Callee's PC marker is not used anymore. Pass Function::null() to set to 0.
65 builder->AddPcMarker(Function::Handle(), slot_ix++); 65 builder->AddPcMarker(Function::Handle(), slot_ix++);
66 66
67 // Current FP and PC. 67 // Current FP and PC.
68 builder->AddCallerFp(slot_ix++); 68 builder->AddCallerFp(slot_ix++);
69 builder->AddReturnAddress(current->function(), 69 builder->AddReturnAddress(current->function(),
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler, 139 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler,
140 intptr_t stub_ix) { 140 intptr_t stub_ix) {
141 // Calls do not need stubs, they share a deoptimization trampoline. 141 // Calls do not need stubs, they share a deoptimization trampoline.
142 ASSERT(reason() != kDeoptAtCall); 142 ASSERT(reason() != kDeoptAtCall);
143 Assembler* assem = compiler->assembler(); 143 Assembler* assem = compiler->assembler();
144 #define __ assem-> 144 #define __ assem->
145 __ Comment("Deopt stub for id %"Pd"", deopt_id()); 145 __ Comment("Deopt stub for id %"Pd"", deopt_id());
146 __ Bind(entry_label()); 146 __ Bind(entry_label());
147 if (FLAG_trap_on_deoptimization) __ int3(); 147 if (FLAG_trap_on_deoptimization) __ int3();
148 148
149 ASSERT(deoptimization_env() != NULL); 149 ASSERT(deopt_env() != NULL);
150 150
151 __ call(&StubCode::DeoptimizeLabel()); 151 __ call(&StubCode::DeoptimizeLabel());
152 set_pc_offset(assem->CodeSize()); 152 set_pc_offset(assem->CodeSize());
153 __ int3(); 153 __ int3();
154 #undef __ 154 #undef __
155 } 155 }
156 156
157 157
158 #define __ assembler()-> 158 #define __ assembler()->
159 159
(...skipping 1773 matching lines...) Expand 10 before | Expand all | Expand 10 after
1933 __ movups(reg, Address(RSP, 0)); 1933 __ movups(reg, Address(RSP, 0));
1934 __ addq(RSP, Immediate(kFpuRegisterSize)); 1934 __ addq(RSP, Immediate(kFpuRegisterSize));
1935 } 1935 }
1936 1936
1937 1937
1938 #undef __ 1938 #undef __
1939 1939
1940 } // namespace dart 1940 } // namespace dart
1941 1941
1942 #endif // defined TARGET_ARCH_X64 1942 #endif // defined TARGET_ARCH_X64
OLDNEW
« runtime/vm/flow_graph_compiler.h ('K') | « runtime/vm/flow_graph_compiler_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698