Issue 14991010: Make breakpoints on == fire reliably

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14991010: Make breakpoints on == fire reliably (Closed)

Created:
7 years, 7 months ago by hausner

Modified:
7 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make breakpoints on == fire reliably Add breakpoints in the path taken if one of the operands in a == b is null. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22857

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -21 lines)			Patch
M	runtime/vm/code_generator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	6 chunks	+30 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	2 chunks	+14 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

hausner

Committed patchset #1 manually as r22857 (presubmit successful).

7 years, 7 months ago (2013-05-17 17:08:16 UTC) #3

Message was sent while issue was closed.

Thank you.