Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 14991010: Make breakpoints on == fire reliably (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 } 417 }
418 } else { 418 } else {
419 // Call stub, load IC data in register. The stub will update ICData if 419 // Call stub, load IC data in register. The stub will update ICData if
420 // necessary. 420 // necessary.
421 Register ic_data_reg = locs->temp(0).reg(); 421 Register ic_data_reg = locs->temp(0).reg();
422 ASSERT(ic_data_reg == R5); // Stub depends on it. 422 ASSERT(ic_data_reg == R5); // Stub depends on it.
423 __ LoadObject(ic_data_reg, equality_ic_data); 423 __ LoadObject(ic_data_reg, equality_ic_data);
424 // Pass left in R1 and right in R0. 424 // Pass left in R1 and right in R0.
425 compiler->GenerateCall(token_pos, 425 compiler->GenerateCall(token_pos,
426 &StubCode::EqualityWithNullArgLabel(), 426 &StubCode::EqualityWithNullArgLabel(),
427 PcDescriptors::kOther, 427 PcDescriptors::kEqualNull,
428 locs); 428 locs);
429 } 429 }
430 __ Bind(&check_ne); 430 __ Bind(&check_ne);
431 if (kind == Token::kNE) { 431 if (kind == Token::kNE) {
432 // Negate the condition: true label returns false and vice versa. 432 // Negate the condition: true label returns false and vice versa.
433 __ CompareObject(R0, Bool::True()); 433 __ CompareObject(R0, Bool::True());
434 __ LoadObject(R0, Bool::True(), NE); 434 __ LoadObject(R0, Bool::True(), NE);
435 __ LoadObject(R0, Bool::False(), EQ); 435 __ LoadObject(R0, Bool::False(), EQ);
436 } 436 }
437 __ Bind(&equality_done); 437 __ Bind(&equality_done);
(...skipping 2434 matching lines...) Expand 10 before | Expand all | Expand 10 after
2872 compiler->GenerateCall(token_pos(), 2872 compiler->GenerateCall(token_pos(),
2873 &label, 2873 &label,
2874 PcDescriptors::kOther, 2874 PcDescriptors::kOther,
2875 locs()); 2875 locs());
2876 __ Drop(2); // Discard type arguments and receiver. 2876 __ Drop(2); // Discard type arguments and receiver.
2877 } 2877 }
2878 2878
2879 } // namespace dart 2879 } // namespace dart
2880 2880
2881 #endif // defined TARGET_ARCH_ARM 2881 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698