Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 14991010: Make breakpoints on == fire reliably (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1690 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 } 1701 }
1702 1702
1703 1703
1704 // Megamorphic call is currently implemented as IC call but through a stub 1704 // Megamorphic call is currently implemented as IC call but through a stub
1705 // that does not check/count function invocations. 1705 // that does not check/count function invocations.
1706 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) { 1706 void StubCode::GenerateMegamorphicCallStub(Assembler* assembler) {
1707 GenerateNArgsCheckInlineCacheStub(assembler, 1); 1707 GenerateNArgsCheckInlineCacheStub(assembler, 1);
1708 } 1708 }
1709 1709
1710 1710
1711 // EDX: Arguments descriptor array. 1711 // ECX: ICData
1712 void StubCode::GenerateBreakpointEqNullStub(Assembler* assembler) {
1713 __ EnterStubFrame();
1714 __ pushl(ECX);
1715 __ CallRuntime(kBreakpointEqualNullHandlerRuntimeEntry);
1716 __ popl(ECX);
1717 __ LeaveFrame();
1718 __ jmp(&StubCode::EqualityWithNullArgLabel());
1719 }
1720
1721
1722 // EDX: Arguments descriptor array.
1712 void StubCode::GenerateBreakpointClosureStub(Assembler* assembler) { 1723 void StubCode::GenerateBreakpointClosureStub(Assembler* assembler) {
1713 __ EnterStubFrame(); 1724 __ EnterStubFrame();
1714 __ pushl(EDX); // Push arguments descriptor. 1725 __ pushl(EDX); // Push arguments descriptor.
1715 __ CallRuntime(kBreakpointClosureHandlerRuntimeEntry); 1726 __ CallRuntime(kBreakpointClosureHandlerRuntimeEntry);
1716 __ popl(EDX); // Restore arguments descriptor. 1727 __ popl(EDX); // Restore arguments descriptor.
1717 __ LeaveFrame(); 1728 __ LeaveFrame();
1718 __ jmp(&StubCode::CallClosureFunctionLabel()); 1729 __ jmp(&StubCode::CallClosureFunctionLabel());
1719 } 1730 }
1720 1731
1721 1732
1722 // EDX: Arguments descriptor array. 1733 // EDX: Arguments descriptor array.
1723 // TOS(0): return address (Dart code). 1734 // TOS(0): return address (Dart code).
1724 void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) { 1735 void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) {
1725 // Create a stub frame as we are pushing some objects on the stack before 1736 // Create a stub frame as we are pushing some objects on the stack before
1726 // calling into the runtime. 1737 // calling into the runtime.
1727 __ EnterStubFrame(); 1738 __ EnterStubFrame();
1728 __ pushl(EDX); // Preserve arguments descriptor. 1739 __ pushl(EDX); // Preserve arguments descriptor.
1729 const Immediate& raw_null = 1740 const Immediate& raw_null =
1730 Immediate(reinterpret_cast<intptr_t>(Object::null())); 1741 Immediate(reinterpret_cast<intptr_t>(Object::null()));
1731 __ pushl(raw_null); // Room for result. 1742 __ pushl(raw_null); // Room for result.
1732 __ CallRuntime(kBreakpointStaticHandlerRuntimeEntry); 1743 __ CallRuntime(kBreakpointStaticHandlerRuntimeEntry);
1733 __ popl(EAX); // Code object. 1744 __ popl(EAX); // Code object.
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 __ Bind(&done); 2146 __ Bind(&done);
2136 __ popl(temp); 2147 __ popl(temp);
2137 __ popl(right); 2148 __ popl(right);
2138 __ popl(left); 2149 __ popl(left);
2139 __ ret(); 2150 __ ret();
2140 } 2151 }
2141 2152
2142 } // namespace dart 2153 } // namespace dart
2143 2154
2144 #endif // defined TARGET_ARCH_IA32 2155 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698