Issue 14845021: Cleanups: addressed your comments from https://codereview.chromium.org/14962008/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14845021: Cleanups: addressed your comments from https://codereview.chromium.org/14962008/ (Closed)

Created:
7 years, 7 months ago by srdjan

Modified:
7 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -38 lines)			Patch
M	runtime/lib/double.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/integers.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bigint_operations.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/bigint_operations.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/bigint_operations_test.cc	View	1	1 chunk	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	9 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

srdjan

7 years, 7 months ago (2013-05-17 23:45:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r22881 (presubmit successful).