Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2198)

Unified Diff: runtime/vm/bigint_operations.cc

Issue 14845021: Cleanups: addressed your comments from https://codereview.chromium.org/14962008/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bigint_operations.h ('k') | runtime/vm/bigint_operations_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/bigint_operations.cc
===================================================================
--- runtime/vm/bigint_operations.cc (revision 22880)
+++ runtime/vm/bigint_operations.cc (working copy)
@@ -605,7 +605,7 @@
}
-bool BigintOperations::FitsIntoMint(const Bigint& bigint) {
+bool BigintOperations::FitsIntoInt64(const Bigint& bigint) {
intptr_t bigint_length = bigint.Length();
if (bigint_length == 0) {
return true;
@@ -663,11 +663,11 @@
}
-int64_t BigintOperations::ToMint(const Bigint& bigint) {
+int64_t BigintOperations::ToInt64(const Bigint& bigint) {
if (bigint.IsZero()) {
return 0;
}
- ASSERT(FitsIntoMint(bigint));
+ ASSERT(FitsIntoInt64(bigint));
int64_t value = AbsToUint64(bigint);
if (bigint.IsNegative()) {
value = -value;
« no previous file with comments | « runtime/vm/bigint_operations.h ('k') | runtime/vm/bigint_operations_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698