Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: runtime/vm/bigint_operations_test.cc

Issue 14845021: Cleanups: addressed your comments from https://codereview.chromium.org/14962008/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bigint_operations.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/bigint_operations_test.cc
===================================================================
--- runtime/vm/bigint_operations_test.cc (revision 22880)
+++ runtime/vm/bigint_operations_test.cc (working copy)
@@ -79,45 +79,45 @@
const Bigint& one = Bigint::Handle(BigintOperations::NewFromInt64(1));
big = BigintOperations::NewFromInt64(kMinInt64);
- EXPECT(BigintOperations::FitsIntoMint(big));
- int64_t back = BigintOperations::ToMint(big);
+ EXPECT(BigintOperations::FitsIntoInt64(big));
+ int64_t back = BigintOperations::ToInt64(big);
EXPECT_EQ(kMinInt64, back);
big = BigintOperations::Subtract(big, one);
- EXPECT(!BigintOperations::FitsIntoMint(big));
+ EXPECT(!BigintOperations::FitsIntoInt64(big));
big = BigintOperations::NewFromInt64(kMaxInt64);
- EXPECT(BigintOperations::FitsIntoMint(big));
- back = BigintOperations::ToMint(big);
+ EXPECT(BigintOperations::FitsIntoInt64(big));
+ back = BigintOperations::ToInt64(big);
EXPECT_EQ(kMaxInt64, back);
big = BigintOperations::Add(big, one);
- EXPECT(!BigintOperations::FitsIntoMint(big));
+ EXPECT(!BigintOperations::FitsIntoInt64(big));
}
TEST_CASE(BigintUint64) {
const Bigint& one = Bigint::Handle(BigintOperations::NewFromUint64(1));
- EXPECT(BigintOperations::FitsIntoMint(one));
+ EXPECT(BigintOperations::FitsIntoInt64(one));
EXPECT(BigintOperations::FitsIntoUint64(one));
Bigint& big = Bigint::Handle(BigintOperations::NewFromUint64(kMaxUint64));
- EXPECT(!BigintOperations::FitsIntoMint(big));
+ EXPECT(!BigintOperations::FitsIntoInt64(big));
EXPECT(BigintOperations::FitsIntoUint64(big));
uint64_t back = BigintOperations::ToUint64(big);
EXPECT_EQ(kMaxUint64, back);
big = BigintOperations::Add(big, one);
- EXPECT(!BigintOperations::FitsIntoMint(big));
+ EXPECT(!BigintOperations::FitsIntoInt64(big));
EXPECT(!BigintOperations::FitsIntoUint64(big));
big = BigintOperations::Subtract(big, one);
- EXPECT(!BigintOperations::FitsIntoMint(big));
+ EXPECT(!BigintOperations::FitsIntoInt64(big));
EXPECT(BigintOperations::FitsIntoUint64(big));
big = BigintOperations::ShiftRight(big, 1);
- EXPECT(BigintOperations::FitsIntoMint(big));
+ EXPECT(BigintOperations::FitsIntoInt64(big));
EXPECT(BigintOperations::FitsIntoUint64(big));
}
« no previous file with comments | « runtime/vm/bigint_operations.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698