Issue 14769009: Remove v8 source dependency, enable more compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14769009: Remove v8 source dependency, enable more compiler warnings (Closed)

Created:
7 years, 7 months ago by kustermann

Modified:
7 years, 7 months ago

Reviewers:
ricow1, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove v8 source dependency, enable more compiler warnings R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22299

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -20 lines)			Patch
M	dart/dart.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	dart/tools/gyp/all.gypi	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	dart/tools/gyp/common.gypi	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	dart/tools/gyp/configurations.gypi	View	1 chunk	+1 line, -4 lines	1 comment	Download
M	dart/tools/gyp/configurations_make.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/tools/gyp/configurations_xcode.gypi	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	deps/all.deps/DEPS	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

Committed patchset #1 manually as r22299 (presubmit successful).

7 years, 7 months ago (2013-05-02 07:21:23 UTC) #3

Ivan Posva

7 years, 7 months ago (2013-05-02 08:22:13 UTC) #4

Message was sent while issue was closed.

THANKS!

-Ivan

https://codereview.chromium.org/14769009/diff/1/dart/tools/gyp/configurations...
File dart/tools/gyp/configurations.gypi (right):

https://codereview.chromium.org/14769009/diff/1/dart/tools/gyp/configurations...
dart/tools/gyp/configurations.gypi:11: # TODO(vm-team): Convert old style casts
to C++ casts.
There shouldn't be any, but we will definitely clean it up now.

Expand Messages | Collapse Messages