Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/tools/gyp/configurations_make.gypi

Issue 14769009: Remove v8 source dependency, enable more compiler warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/tools/gyp/configurations.gypi ('K') | « dart/tools/gyp/configurations.gypi ('k') | dart/tools/gyp/configurations_xcode.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/gyp/configurations_make.gypi
diff --git a/dart/tools/gyp/configurations_make.gypi b/dart/tools/gyp/configurations_make.gypi
index a2b9e8a391c871af71213ae2c30aa35f87bd2c16..abced4d4e2ef2661f2297254e1f81ecace0af4fb 100644
--- a/dart/tools/gyp/configurations_make.gypi
+++ b/dart/tools/gyp/configurations_make.gypi
@@ -17,8 +17,7 @@
'-Wnon-virtual-dtor',
'-Wvla',
'-Wno-conversion-null',
- # TODO(v8-team): Fix V8 build.
- #'-Woverloaded-virtual',
+ '-Woverloaded-virtual',
'-g3',
'-ggdb3',
# TODO(iposva): Figure out if we need to pass anything else.
« dart/tools/gyp/configurations.gypi ('K') | « dart/tools/gyp/configurations.gypi ('k') | dart/tools/gyp/configurations_xcode.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698