dart/tools/gyp/configurations.gypi - Issue 14769009: Remove v8 source dependency, enable more compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/gyp/configurations.gypi

Issue 14769009: Remove v8 source dependency, enable more compiler warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/gyp/configurations.gypi

diff --git a/dart/tools/gyp/configurations.gypi b/dart/tools/gyp/configurations.gypi

index f717f76c83d72499fa71d669a999c869e9f6441d..680433087b18a5309f2c78fe7be2827a1d21ee88 100644

--- a/dart/tools/gyp/configurations.gypi

+++ b/dart/tools/gyp/configurations.gypi

@@ -8,16 +8,13 @@

'-Wall',

'-Wextra', # Also known as -W.

'-Wno-unused-parameter',

- # TODO(v8-team): Fix V8 build.

+ # TODO(vm-team): Convert old style casts to C++ casts.

Ivan Posva 2013/05/02 08:22:13 There shouldn't be any, but we will definitely cle

#'-Wold-style-cast',

# Default value. This may be overridden in a containing project gyp.

'target_arch%': 'ia32',

- # Don't use separate host toolset for compiling V8.

- 'want_separate_host_toolset': 0,

'conditions': [

['"<(target_arch)"=="ia32"', { 'dart_target_arch': 'IA32', }],

['"<(target_arch)"=="x64"', { 'dart_target_arch': 'X64', }],

« no previous file with comments | « dart/tools/gyp/common.gypi ('k') | dart/tools/gyp/configurations_make.gypi » ('j') | no next file with comments »