Issue 14672037: Implements FPU compare and branching for MIPS simulator, assembler, disassembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14672037: Implements FPU compare and branching for MIPS simulator, assembler, disassembler. (Closed)

Created:
7 years, 7 months ago by zra

Modified:
7 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Implements FPU compare and branching for MIPS simulator, assembler, disassembler. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=22752

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+450 lines, -85 lines)			Patch
M	runtime/vm/assembler_mips.h	View		4 chunks	+90 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View		3 chunks	+217 lines, -61 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1 2	3 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View	1	2 chunks	+41 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View		3 chunks	+64 lines, -19 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

zra

Committed patchset #3 manually as r22752 (presubmit successful).

7 years, 7 months ago (2013-05-15 18:37:52 UTC) #3

Message was sent while issue was closed.

On 2013/05/15 16:44:23, regis wrote:
> LGTM

Thanks!