Issue 14425003: Make List.remove return boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14425003: Make List.remove return boolean. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, regis

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make List.remove return boolean. Add remove to Queue's interface and make it return bool on change. Added more tests for list operations. Fixed bugs and omissions found by tests. http://dartbug.com/10042 http://dartbug.com/10122 Committed: https://code.google.com/p/dart/source/detail?r=21867

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+382 lines, -196 lines)			Patch
M	runtime/lib/array.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/lib/typeddata.dart	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	sdk/lib/_collection_dev/list.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/collection/list.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	sdk/lib/collection/queue.dart	View	5 chunks	+21 lines, -28 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	25 chunks	+30 lines, -27 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	25 chunks	+30 lines, -27 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/web_sql/dartium/web_sql_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/list_test.dart	View	2 chunks	+239 lines, -77 lines	0 comments	Download
M	tests/corelib/queue_test.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	tools/dom/templates/immutable_list_mixin.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years, 8 months ago (2013-04-23 11:13:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21867 (presubmit successful).

Expand Messages | Collapse Messages