tools/dom/templates/html/impl/impl_Node.darttemplate - Issue 14425003: Make List.remove return boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 14425003: Make List.remove return boolean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/templates/html/impl/impl_Node.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate

index af1644763a7f2b71f4ede4194513b671918cbfbe..1d84f30f2c48f8ecc55f7de19152e50f4861bafb 100644

--- a/tools/dom/templates/html/impl/impl_Node.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate

@@ -106,11 +106,12 @@ $endif

return result;

}

- void remove(Object object) {

- if (object is! Node) return;

+ bool remove(Object object) {

+ if (object is! Node) return false;

Node node = object;

- if (!identical(_this, node.parentNode)) return;

+ if (!identical(_this, node.parentNode)) return false;

_this.$dom_removeChild(node);

+ return true;

}

void _filter(bool test(Node node), bool removeMatching) {