Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: runtime/lib/typeddata.dart

Issue 14425003: Make List.remove return boolean. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | sdk/lib/_collection_dev/list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typeddata.dart
diff --git a/runtime/lib/typeddata.dart b/runtime/lib/typeddata.dart
index ddf79f444898c7644a78360a0e30cf623f179abb..75cd3624843055d63b5d7b0e72816ba01d9b1512 100644
--- a/runtime/lib/typeddata.dart
+++ b/runtime/lib/typeddata.dart
@@ -373,6 +373,16 @@ abstract class _TypedListBase {
"Cannot add to a non-extendable array");
}
+ void insert(int index, value) {
+ throw new UnsupportedError(
+ "Cannot insert into a non-extendable array");
+ }
+
+ void insertAll(int index, Iterable values) {
+ throw new UnsupportedError(
+ "Cannot insert into a non-extendable array");
+ }
+
void sort([int compare(var a, var b)]) {
return IterableMixinWorkaround.sortList(this, compare);
}
@@ -395,7 +405,12 @@ abstract class _TypedListBase {
"Cannot remove from a non-extendable array");
}
- void remove(Object element) {
+ bool remove(Object element) {
+ throw new UnsupportedError(
+ "Cannot remove from a non-extendable array");
+ }
+
+ bool removeAt(int index) {
throw new UnsupportedError(
"Cannot remove from a non-extendable array");
}
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | sdk/lib/_collection_dev/list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698