Issue 14206002: Adds some floating point instructions to MIPS simulator, assembler, disassembler.

Issue 14206002: Adds some floating point instructions to MIPS simulator, assembler, disassembler. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds some floating point instructions to MIPS simulator, assembler, disassembler. Committed: https://code.google.com/p/dart/source/detail?r=21376

Patch Set 3 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+695 lines, -14 lines)			Patch
M	runtime/vm/assembler_mips.h	View		11 chunks	+108 lines, -0 lines	2 comments	Download
M	runtime/vm/assembler_mips_test.cc	View	1 2	1 chunk	+158 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1 2	6 chunks	+70 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_mips.cc	View	1 2	11 chunks	+144 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View		3 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 2	11 chunks	+200 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM! https://codereview.chromium.org/14206002/diff/10001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/14206002/diff/10001/runtime/vm/assembler_mips.h#newcode641 runtime/vm/assembler_mips.h:641: void LoadImmediate(FRegister rd, float value) { I am ...

7 years, 8 months ago (2013-04-12 17:08:56 UTC) #2

zra

Thanks! https://codereview.chromium.org/14206002/diff/10001/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/14206002/diff/10001/runtime/vm/assembler_mips.h#newcode641 runtime/vm/assembler_mips.h:641: void LoadImmediate(FRegister rd, float value) { On 2013/04/12 ...

7 years, 8 months ago (2013-04-12 17:19:26 UTC) #3

zra

7 years, 8 months ago (2013-04-12 17:25:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21376 (presubmit successful).

Expand Messages | Collapse Messages