Issue 14081033: Re-apply CL https://codereview.chromium.org/14217011/, by fixing the internal HashMap implementatio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14081033: Re-apply CL https://codereview.chromium.org/14217011/, by fixing the internal HashMap implementatio… (Closed)

Created:
7 years, 8 months ago by ngeoffray

Modified:
7 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Re-apply CL https://codereview.chromium.org/14217011/, by fixing the internal HashMap implementation to not use its opaque objects in a way visible to the compiler. Committed: https://code.google.com/p/dart/source/detail?r=22019

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View		7 chunks	+40 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/type_mask.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/field_type_simple_inferer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

Patchset 1 contains the original patch. Patchset 2 contains the fix.

7 years, 8 months ago (2013-04-25 09:11:35 UTC) #1

ngeoffray

7 years, 8 months ago (2013-04-25 09:50:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22019 (presubmit successful).