Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart

Issue 14081033: Re-apply CL https://codereview.chromium.org/14217011/, by fixing the internal HashMap implementatio… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart (revision 22005)
+++ sdk/lib/_internal/compiler/implementation/lib/collection_patch.dart (working copy)
@@ -265,8 +265,14 @@
// We only store non-null entries in the table, so we have to
// change null values to refer to the table itself. Such values
// will be recognized and mapped back to null on access.
- if (value == null) value = table;
- JS('void', '#[#] = #', table, key, value);
+ if (value == null) {
+ // Do not update [value] with [table], otherwise our
+ // optimizations could be confused by this opaque object being
+ // now used for more things than storing and fetching from it.
+ JS('void', '#[#] = #', table, key, table);
+ } else {
+ JS('void', '#[#] = #', table, key, value);
+ }
}
static void _deleteTableEntry(var table, var key) {
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698