If we know a call will actually not reach an element anymore, because we have more information on t…

If we know a call will actually not reach an element anymore, because we have more information on the receiver type, unregister that call.

Committed: https://code.google.com/p/dart/source/detail?r=22003

[ngeoffray, 2013-04-23 14:04:41]

Nothing revolutionary in our benchmarks though. We do save on code size on swarm
(0.5%).

[kasperl, 2013-04-23 14:39:03]

LGTM.

https://codereview.chromium.org/14217011/diff/1/tests/compiler/dart2js/simple...
File tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart (right):

https://codereview.chromium.org/14217011/diff/1/tests/compiler/dart2js/simple...
tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart:18: //
String::+, or int+. After all methods have been analyzed, we know
int::+

[ngeoffray, 2013-04-23 14:42:00]

Thanks Kasper.

https://codereview.chromium.org/14217011/diff/1/tests/compiler/dart2js/simple...
File tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart (right):

https://codereview.chromium.org/14217011/diff/1/tests/compiler/dart2js/simple...
tests/compiler/dart2js/simple_inferrer_unregister_call_test.dart:18: //
String::+, or int+. After all methods have been analyzed, we know
On 2013/04/23 14:39:03, kasperl wrote:
> int::+

Done.

[ngeoffray, 2013-04-24 12:17:02]

PTAL. I have updated the code to handle noSuchMethod. I'm not really happy with
it, but we can fix that in a later CL.

[kasperl, 2013-04-24 12:39:26]

LGTM.

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:957:
// TOD(ngeoffray) : The following noSuchMethod handling is a bit
TOD -> TODO.

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:961:
if (element.name != selector.name) {
Lift the convoluted code out into a method of its own so it really sticks out.

[ngeoffray, 2013-04-24 13:25:46]

Thanks Kasper.

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:957:
// TOD(ngeoffray) : The following noSuchMethod handling is a bit
On 2013/04/24 12:39:26, kasperl wrote:
> TOD -> TODO.

Done.

https://codereview.chromium.org/14217011/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:961:
if (element.name != selector.name) {
On 2013/04/24 12:39:26, kasperl wrote:
> Lift the convoluted code out into a method of its own so it really sticks out.

Done.

[ngeoffray, 2013-04-25 07:16:39]

Committed patchset #4 manually as r22003 (presubmit successful).