Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 140793010: Eliminate another debugger stub (Closed)

Created:
6 years, 11 months ago by hausner
Modified:
6 years, 11 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate another debugger stub This change replaces https://codereview.chromium.org/135213002/ The specialized debugger stub call for static method calls is no longer needed. It was introduced because once upon a time, the static method call stub used to patch the call site when the target was compiled. The VM stopped patching unoptimized static calls a long time ago. Thus we can treat a static call like a regular runtime call when patching it to set a breakpoint. Bonus fix: single step runtime callback on mips was broken. The enter/leave stub frame were missing. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -176 lines) Patch
M runtime/vm/assembler_x64.h View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/code_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M runtime/vm/debugger_arm.cc View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/debugger_ia32.cc View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/debugger_mips.cc View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/debugger_x64.cc View 1 chunk +1 line, -10 lines 0 comments Download
M runtime/vm/stub_code.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 7 chunks +8 lines, -29 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
This is essentially the same as https://codereview.chromium.org/135213002/ which you already LGTM'd. I'm abandoning that change ...
6 years, 11 months ago (2014-01-17 18:44:14 UTC) #1
srdjan
lgtm
6 years, 11 months ago (2014-01-17 18:55:47 UTC) #2
hausner
6 years, 11 months ago (2014-01-17 19:09:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698