Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: runtime/vm/code_generator.cc

Issue 140793010: Eliminate another debugger stub (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/debugger_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 31898)
+++ runtime/vm/code_generator.cc (working copy)
@@ -815,32 +815,6 @@
// Gets called from debug stub when code reaches a breakpoint.
-DEFINE_RUNTIME_ENTRY(BreakpointStaticHandler, 0) {
- ASSERT(isolate->debugger() != NULL);
- isolate->debugger()->SignalBpReached();
- // Make sure the static function that is about to be called is
- // compiled. The stub will jump to the entry point without any
- // further tests.
- DartFrameIterator iterator;
- StackFrame* caller_frame = iterator.NextFrame();
- ASSERT(caller_frame != NULL);
- const Code& code = Code::Handle(caller_frame->LookupDartCode());
- ASSERT(!code.is_optimized());
- const Function& function =
- Function::Handle(CodePatcher::GetUnoptimizedStaticCallAt(
- caller_frame->pc(), code, NULL));
-
- if (!function.HasCode()) {
- const Error& error = Error::Handle(Compiler::CompileFunction(function));
- if (!error.IsNull()) {
- Exceptions::PropagateError(error);
- }
- }
- arguments.SetReturn(Code::ZoneHandle(function.CurrentCode()));
-}
-
-
-// Gets called from debug stub when code reaches a breakpoint.
DEFINE_RUNTIME_ENTRY(BreakpointDynamicHandler, 0) {
ASSERT(isolate->debugger() != NULL);
isolate->debugger()->SignalBpReached();
« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/debugger_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698