Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 140793010: Eliminate another debugger stub (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 31898)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1861,34 +1861,6 @@
}
-// ECX: ICData (unoptimized static call).
-// TOS(0): return address (Dart code).
-void StubCode::GenerateBreakpointStaticStub(Assembler* assembler) {
- // Create a stub frame as we are pushing some objects on the stack before
- // calling into the runtime.
- __ EnterStubFrame();
- __ pushl(ECX); // Preserve ICData for unoptimized call.
- const Immediate& raw_null =
- Immediate(reinterpret_cast<intptr_t>(Object::null()));
- __ pushl(raw_null); // Room for result.
- __ CallRuntime(kBreakpointStaticHandlerRuntimeEntry, 0);
- __ popl(EAX); // Code object.
- __ popl(ECX); // Restore ICData.
- __ LeaveFrame();
-
- // Load arguments descriptor into EDX.
- __ movl(EDX, FieldAddress(ECX, ICData::arguments_descriptor_offset()));
- // Now call the static function. The breakpoint handler function
- // ensures that the call target is compiled.
- // Note that we can't just jump to the CallStatic function stub
- // here since that stub would patch the call site with the
- // static function address.
- __ movl(ECX, FieldAddress(EAX, Code::instructions_offset()));
- __ addl(ECX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
- __ jmp(ECX);
-}
-
-
// ECX: Inline cache data array.
// TOS(0): return address (Dart code).
void StubCode::GenerateBreakpointDynamicStub(Assembler* assembler) {
« no previous file with comments | « runtime/vm/stub_code_arm.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698