Added new version of reduce.

Added new version of reduce.

Removed min/max and uses of min/max.

Committed: https://code.google.com/p/dart/source/detail?r=21258

[floitsch, 2013-04-10 15:14:07]

LGTM. after you cleaned up the bad merge.

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart#newcod...
runtime/lib/array.dart:117: reduce(E combine(E value, E element)) {
Return type is E.

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart#newcod...
runtime/lib/array.dart:360: reduce(E combine(E value, E element)) {
return type is E.

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart
File runtime/lib/typeddata.dart (right):

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart#ne...
runtime/lib/typeddata.dart:310: dynamic reduce(dynamic combine(value, element))
{
Return type is int.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:43: Iterator iteator = iterable.iterator;
iterator

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (left):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:330: void clear() { this.length = 0; }
Didn't you just add them?
bad merge?

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:16: * Abstract implementation of a fixed-length
list.
I thought we agreed that these classes are not in dart.collection.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:160: String join([String separator]) {
bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:162: if (separator != null && !separator.isEmpty) {
bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:171: buffer.write("${this[i]}");
bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:180: buffer.write("${this[i]}");
bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:424: if (startIndex >= a.length) {
I guess bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:436: Iterable<E> get reversed => new
_ReversedListIterable(this);
bad merge.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:444: abstract class FixedLengthListMixin<E>  {
This shouldn't be here either.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:523: abstract class UnmodifiableListMixin<E> {
ditto.

[Lasse Reichstein Nielsen, 2013-04-11 07:54:04]

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart#newcod...
runtime/lib/array.dart:117: reduce(E combine(E value, E element)) {
On 2013/04/10 15:14:07, floitsch wrote:
> Return type is E.

Done.

https://codereview.chromium.org/14071002/diff/1/runtime/lib/array.dart#newcod...
runtime/lib/array.dart:360: reduce(E combine(E value, E element)) {
On 2013/04/10 15:14:07, floitsch wrote:
> return type is E.

Done.

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart
File runtime/lib/typeddata.dart (right):

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart#ne...
runtime/lib/typeddata.dart:310: dynamic reduce(dynamic combine(value, element))
{
Why are the iterables untyped? I was assuming typed arrays would work with both
int and double elements.
I can see that other elements are typed as int, but in general, the types are
absent from TypedData.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:16: * Abstract implementation of a fixed-length
list.
Yes, yet another bad merge. Seems I was working on a stale version of this file.

[Lasse Reichstein Nielsen, 2013-04-11 08:00:23]

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/collection...
File sdk/lib/collection/collections.dart (right):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/collection...
sdk/lib/collection/collections.dart:43: Iterator iteator = iterable.iterator;
On 2013/04/10 15:14:07, floitsch wrote:
> iterator

Done.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:160: String join([String separator]) {
On 2013/04/10 15:14:07, floitsch wrote:
> bad merge.

Done.

https://codereview.chromium.org/14071002/diff/1/sdk/lib/collection/list.dart#...
sdk/lib/collection/list.dart:162: if (separator != null && !separator.isEmpty) {
On 2013/04/10 15:14:07, floitsch wrote:
> bad merge.

Done.

[Lasse Reichstein Nielsen, 2013-04-11 08:33:03]

Committed patchset #3 manually as r21258 (presubmit successful).

[floitsch, 2013-04-11 09:36:41]

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart
File runtime/lib/typeddata.dart (right):

https://codereview.chromium.org/14071002/diff/1/runtime/lib/typeddata.dart#ne...
runtime/lib/typeddata.dart:310: dynamic reduce(dynamic combine(value, element))
{
On 2013/04/11 07:54:04, Lasse Reichstein Nielsen wrote:
> Why are the iterables untyped? I was assuming typed arrays would work with
both
> int and double elements.
> I can see that other elements are typed as int, but in general, the types are
> absent from TypedData.

If they work only on ints and nums then they should probably be typed "num".
The joy of non-written types...

[nweiz, 2013-04-12 19:47:33]

We appreciate you making these changes, but please do CC Bob and myself when you
make changes to our code.

https://codereview.chromium.org/14071002/diff/11001/pkg/stack_trace/lib/src/t...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/14071002/diff/11001/pkg/stack_trace/lib/src/t...
pkg/stack_trace/lib/src/trace.dart:8: import 'dart:math';
Please import dart:math with a prefix. It has a lot of top-level members that
can conflict easily. Same goes for utils/tests/pub/command_line_config.dart.

[floitsch, 2013-04-13 13:15:51]

https://codereview.chromium.org/14071002/diff/11001/pkg/stack_trace/lib/src/t...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/14071002/diff/11001/pkg/stack_trace/lib/src/t...
pkg/stack_trace/lib/src/trace.dart:8: import 'dart:math';
On 2013/04/12 19:47:33, nweiz wrote:
> Please import dart:math with a prefix. It has a lot of top-level members that
> can conflict easily. Same goes for utils/tests/pub/command_line_config.dart.

done in https://codereview.chromium.org/14111004