Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: sdk/lib/svg/dartium/svg_dartium.dart

Issue 14071002: Added new version of reduce. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed more uses of max, and a few bugs. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/svg/dartium/svg_dartium.dart
diff --git a/sdk/lib/svg/dartium/svg_dartium.dart b/sdk/lib/svg/dartium/svg_dartium.dart
index ad520f9ea6644fe8d27afac3fb9bfcf5f03c21e7..63d496f46de3dff93d621ce1dd91f0d80cb4638d 100644
--- a/sdk/lib/svg/dartium/svg_dartium.dart
+++ b/sdk/lib/svg/dartium/svg_dartium.dart
@@ -3291,11 +3291,12 @@ class LengthList extends NativeFieldWrapperClass1 implements List<Length> {
// SVG Collections expose numberOfItems rather than length.
int get length => numberOfItems;
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, Length)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ Length reduce(Length combine(Length value, Length element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, Length)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, Length element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -3403,12 +3404,6 @@ class LengthList extends NativeFieldWrapperClass1 implements List<Length> {
throw new StateError("More than one element");
}
- Length min([int compare(Length a, Length b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- Length max([int compare(Length a, Length b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, Length element) {
throw new UnsupportedError("Cannot add to immutable List.");
}
@@ -4013,11 +4008,12 @@ class NumberList extends NativeFieldWrapperClass1 implements List<Number> {
// SVG Collections expose numberOfItems rather than length.
int get length => numberOfItems;
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, Number)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ Number reduce(Number combine(Number value, Number element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, Number)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, Number element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -4125,12 +4121,6 @@ class NumberList extends NativeFieldWrapperClass1 implements List<Number> {
throw new StateError("More than one element");
}
- Number min([int compare(Number a, Number b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- Number max([int compare(Number a, Number b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, Number element) {
throw new UnsupportedError("Cannot add to immutable List.");
}
@@ -5162,11 +5152,12 @@ class PathSegList extends NativeFieldWrapperClass1 implements List<PathSeg> {
// SVG Collections expose numberOfItems rather than length.
int get length => numberOfItems;
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, PathSeg)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ PathSeg reduce(PathSeg combine(PathSeg value, PathSeg element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, PathSeg)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, PathSeg element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -5274,12 +5265,6 @@ class PathSegList extends NativeFieldWrapperClass1 implements List<PathSeg> {
throw new StateError("More than one element");
}
- PathSeg min([int compare(PathSeg a, PathSeg b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- PathSeg max([int compare(PathSeg a, PathSeg b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, PathSeg element) {
throw new UnsupportedError("Cannot add to immutable List.");
}
@@ -6165,11 +6150,12 @@ class StringList extends NativeFieldWrapperClass1 implements List<String> {
// SVG Collections expose numberOfItems rather than length.
int get length => numberOfItems;
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, String)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ String reduce(String combine(String value, String element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, String)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, String element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -6277,12 +6263,6 @@ class StringList extends NativeFieldWrapperClass1 implements List<String> {
throw new StateError("More than one element");
}
- String min([int compare(String a, String b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- String max([int compare(String a, String b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, String element) {
throw new UnsupportedError("Cannot add to immutable List.");
}
@@ -7433,11 +7413,12 @@ class TransformList extends NativeFieldWrapperClass1 implements List<Transform>
// SVG Collections expose numberOfItems rather than length.
int get length => numberOfItems;
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, Transform)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ Transform reduce(Transform combine(Transform value, Transform element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, Transform)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, Transform element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -7545,12 +7526,6 @@ class TransformList extends NativeFieldWrapperClass1 implements List<Transform>
throw new StateError("More than one element");
}
- Transform min([int compare(Transform a, Transform b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- Transform max([int compare(Transform a, Transform b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, Transform element) {
throw new UnsupportedError("Cannot add to immutable List.");
}
@@ -8025,11 +8000,12 @@ class _ElementInstanceList extends NativeFieldWrapperClass1 implements List<Elem
return new FixedSizeListIterator<ElementInstance>(this);
}
- dynamic reduce(dynamic initialValue, dynamic combine(dynamic, ElementInstance)) {
- return IterableMixinWorkaround.reduce(this, initialValue, combine);
+ ElementInstance reduce(ElementInstance combine(ElementInstance value, ElementInstance element)) {
+ return IterableMixinWorkaround.reduce(this, combine);
}
- dynamic fold(dynamic initialValue, dynamic combine(dynamic, ElementInstance)) {
+ dynamic fold(dynamic initialValue,
+ dynamic combine(dynamic previousValue, ElementInstance element)) {
return IterableMixinWorkaround.fold(this, initialValue, combine);
}
@@ -8139,12 +8115,6 @@ class _ElementInstanceList extends NativeFieldWrapperClass1 implements List<Elem
throw new StateError("More than one element");
}
- ElementInstance min([int compare(ElementInstance a, ElementInstance b)]) =>
- IterableMixinWorkaround.min(this, compare);
-
- ElementInstance max([int compare(ElementInstance a, ElementInstance b)]) =>
- IterableMixinWorkaround.max(this, compare);
-
void insert(int index, ElementInstance element) {
throw new UnsupportedError("Cannot add to immutable List.");
}

Powered by Google App Engine
This is Rietveld 408576698