pkg/stack_trace/lib/src/trace.dart - Issue 14071002: Added new version of reduce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/stack_trace/lib/src/trace.dart

Issue 14071002: Added new version of reduce. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Removed more uses of max, and a few bugs. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/stack_trace/lib/src/trace.dart

diff --git a/pkg/stack_trace/lib/src/trace.dart b/pkg/stack_trace/lib/src/trace.dart

index 43a598c872857060bc82e7f6c713c58e8abd212c..bed1d5d89c799419d156dabe75835ffc34572a9a 100644

--- a/pkg/stack_trace/lib/src/trace.dart

+++ b/pkg/stack_trace/lib/src/trace.dart

@@ -5,6 +5,7 @@

library trace;

import 'dart:uri';

+import 'dart:math';

nweiz 2013/04/12 19:47:33 Please import dart:math with a prefix. It has a lo

floitsch 2013/04/13 13:15:51 done in https://codereview.chromium.org/14111004

import 'frame.dart';

@@ -116,7 +117,7 @@ class Trace implements StackTrace {

if (frames.length == '') return '';

// Figure out the longest path so we know how much to pad.

- var longest = frames.map((frame) => frame.location.length).max();

+ var longest = frames.map((frame) => frame.location.length).reduce(max);

// Print out the stack trace nicely formatted.

return frames.map((frame) {

« no previous file with comments | « no previous file | runtime/lib/array.dart » ('j') | no next file with comments »