Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 14055003: Remove HttpClientRequest.response, as it's identical to HttpClientRequest.done. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove HttpClientRequest.response, as it's identical to HttpClientRequest.done. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M pkg/http/lib/src/io_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/io/http.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M tests/standalone/io/http_headers_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-10 11:36:00 UTC) #1
Søren Gjesse
LGTM, nice cleanup.
7 years, 8 months ago (2013-04-10 11:49:22 UTC) #2
Anders Johnsen
7 years, 8 months ago (2013-04-10 12:54:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21198 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698