Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: sdk/lib/io/http_impl.dart

Issue 14055003: Remove HttpClientRequest.response, as it's identical to HttpClientRequest.done. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http.dart ('k') | tests/standalone/io/http_client_request_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index 0f7dafec84211fab9eca808a6e8ce294a21606fc..eefd9c87837193247c336a6fcb2741710307fb15 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -724,7 +724,7 @@ class _HttpClientRequest extends _HttpOutboundMessage<HttpClientResponse>
}
}
- Future<HttpClientResponse> get response {
+ Future<HttpClientResponse> get done {
if (_response == null) {
_response = Future.wait([_responseCompleter.future, super.done])
.then((list) => list[0]);
@@ -732,16 +732,14 @@ class _HttpClientRequest extends _HttpOutboundMessage<HttpClientResponse>
return _response;
}
- Future<HttpClientResponse> get done => response;
-
Future<HttpClientResponse> consume(Stream<List<int>> stream) {
super.consume(stream);
- return response;
+ return done;
}
Future<HttpClientResponse> close() {
super.close();
- return response;
+ return done;
}
int get maxRedirects => _maxRedirects;
« no previous file with comments | « sdk/lib/io/http.dart ('k') | tests/standalone/io/http_client_request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698